[XeVM] Add initial set of operations and conversion tests #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akroviakov
force-pushed
the
akroviak/xevm-conversions
branch
from
e0a6fda to
d59728f
Compare
akroviakov
force-pushed
the
akroviak/xevm-conversions
branch
2 times, most recently
from
3845562 to
3315f73
Compare
kurapov-peter
approved these changes
Dec 17, 2024
Contributor
kurapov-peter
left a comment
kurapov-peter
left a comment
There was a problem hiding this comment.
Looks good with the map for cache levels and the width/pitch/height description (not necessary atm)
akroviakov
force-pushed
the
akroviak/xevm-conversions
branch
3 times, most recently
from
a96e86c to
349bf35
Compare
AndreyPavlenko
approved these changes
Dec 17, 2024
|
|
||
| namespace { | ||
|
|
||
| enum CacheLevel { L1, L2, L3 }; |
Contributor
There was a problem hiding this comment.
Suggested change
| enum CacheLevel { L1, L2, L3 }; | |
| enum class CacheLevel { L1, L2, L3 }; |
| getCacheControlMetadata(ConversionPatternRewriter &rewriter, OpType op, | ||
| const bool isLoad, const std::string &chip) { | ||
| if ((op.getL1CacheControlAttr() == | ||
| xevm::L1StoreCacheControlAttr::get( |
Contributor
There was a problem hiding this comment.
Suggested change
| xevm::L1StoreCacheControlAttr::get( | |
| L1StoreCacheControlAttr::get( |
You may omit the namespace here and below or remove using namespace xevm, seems it's never used.
| static LLVM::CallOp createDeviceFunctionCall( | ||
| ConversionPatternRewriter &rewriter, StringRef funcName, Type retType, | ||
| ArrayRef<Type> argTypes, ArrayRef<Value> args, | ||
| mlir::ArrayRef<std::pair<unsigned, mlir::StringRef>> paramAttrs, |
Contributor
There was a problem hiding this comment.
Suggested change
| mlir::ArrayRef<std::pair<unsigned, mlir::StringRef>> paramAttrs, | |
| ArrayRef<std::pair<unsigned, StringRef>> paramAttrs, |
To be consistent with other args.
| return llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(type, val)); | ||
| } | ||
|
|
||
| static LogicalResult handleDecorationCacheControl(Operation *op, |
Contributor
There was a problem hiding this comment.
Seems the op argument is never used.
akroviakov
force-pushed
the
akroviak/xevm-conversions
branch
from
349bf35 to
c3e7f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds XeVM load/store/prefetch operations and their conversion patterns to llvm. We follow the Triton approach with slight changes (e.g., the cache attribute is handled differently).